Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make buildTopicName(String, String, String) public #318

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make buildTopicName(String, String, String) public #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b942585
Make buildTopicName(String, String, String) public
Nov 15, 2023
3f26849
feat: make buildTopicName(String, String, String) public
Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions dao-api/src/main/java/com/linkedin/mxe/TopicConventionV5.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@
* defined in the DataHub repo due to tight coupling with MXE v4.
*/
public interface TopicConventionV5 {
/**
* Returns the name of the topic based on event type, entity name and aspect name.
*/
@Nonnull
String buildTopicName(@Nonnull String eventType, @Nonnull String entityName, @Nonnull String aspectName);

/**
* Returns the name of the metadata change event topic.
*
Expand Down
3 changes: 2 additions & 1 deletion dao-api/src/main/java/com/linkedin/mxe/TopicConventionV5Impl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,8 @@ private String getDefaultTopicName(@Nonnull Class<?> eventSchema) {
}

@Nonnull
private String buildTopicName(@Nonnull String eventType, @Nonnull String entityName, @Nonnull String aspectName) {
@Override
public String buildTopicName(@Nonnull String eventType, @Nonnull String entityName, @Nonnull String aspectName) {
final String name = _eventPattern.replace(EVENT_TYPE_PLACEHOLDER, eventType)
.replace(ENTITY_PLACEHOLDER, entityName)
.replace(ASPECT_PLACEHOLDER, aspectName);
Expand Down
Loading