Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made nonDollarVirtualColumnsEnabled member of SQLSchemaUtils #360

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rakhiagr
Copy link
Contributor

@rakhiagr rakhiagr commented Feb 16, 2024

The other GMS could have used the methods defined in SQLSchemaUtils. The last change to add boolean nonDollarVirtualColumnsEnabled will break those GMSes once they bump their version.

I have made nonDollarVirtualColumnsEnabled a static member of SQLSchemaUtils which can be initialized when we create an instance of EbeanLocalAccess to set the value of nonDollarVirtualColumnsEnabled and be consistent with the whole instance.

Testing

./gradlew build

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Copy link
Contributor

@yangyangv2 yangyangv2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This global static verifiable setting is unintuitive and error prone. Can we make the fix the ai-metadata-gms instead of including hack solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants