[compat] [controller] add rt topic name in store config #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjun4084346
force-pushed
the
rttopicname
branch
3 times, most recently
from
6cedc00
to
20785a8
Compare
arjun4084346
changed the title
arjun4084346
force-pushed
the
rttopicname
branch
from
d195293
to
154b13a
Compare
lluwm
reviewed
Nov 15, 2024
...ent/src/test/java/com/linkedin/davinci/kafka/consumer/KafkaConsumerServiceDelegatorTest.java
Show resolved
Hide resolved
internal/venice-common/src/main/java/com/linkedin/venice/meta/Version.java
Outdated
Show resolved
Hide resolved
internal/venice-common/src/main/java/com/linkedin/venice/meta/VersionImpl.java
Outdated
Show resolved
Hide resolved
arjun4084346
changed the title
arjun4084346
force-pushed
the
rttopicname
branch
from
9397239
to
f66c463
Compare
arjun4084346
changed the title
arjun4084346
force-pushed
the
rttopicname
branch
from
e85ea7c
to
9c39313
Compare
fix serialization fix tests fix documentation move methods from Version to Utils
arjun4084346
force-pushed
the
rttopicname
branch
from
9c39313
to
59bb408
Compare
arjun4084346
changed the title
arjun4084346
force-pushed
the
rttopicname
branch
from
11090e6
to
114803d
Compare
arjun4084346
force-pushed
the
rttopicname
branch
from
6ffddf4
to
5484ab5
Compare
arjun4084346
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a field
realTimeTopicNamein store and store-version hybrid configIn future, we want to provide users/admin ability to create a new real time topic, probably with some different configurations, e.g. partition count. This new real time topic would co-exist with the old real time topic for some time, so we want to give it a different name.
This PR will make all the components check the real time topic's name, if it exists, in Store/Store-Version hybrid config. If the config does not have any name, it would be assumed, that there is no new topic right now and we can use the old methodology "<store_name>_rt" to determine the real time topic name.
Verson.composeRealTimeTopic method is moved to Utils.
Utils.getRealTimeTopicName are the core methods of this PR.
When store is not hybrid, current version is also not hybrid, and two older versions are using two different rt topics.
This method will return one of those RT topic, because both the RT topics are "active" and will be having data mirroring tasks copying data to/from each other
Note that, in future, when creating new RT topic, I plan to add condition that there should not exists more than one rt topics, because it will increase data replication processes exponentially. So at one point, we will allow only two RT topics
Resolves #XXX
How was this PR tested?
added integration tests.
Does this PR introduce any user-facing changes?