[compat][common][controller] Add store and version configs for target region swap and wait time #1340
+1,934
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clients/venice-admin-tool/src/main/java/com/linkedin/venice/Arg.java
Outdated
Show resolved
Hide resolved
clients/venice-admin-tool/src/main/java/com/linkedin/venice/Arg.java
Outdated
Show resolved
Hide resolved
clients/venice-admin-tool/src/main/java/com/linkedin/venice/Arg.java
Outdated
Show resolved
Hide resolved
misyel
force-pushed
the
mkwong/add-target-region-config
branch
from
aece22d
to
6db24cb
Compare
misyel
changed the title
misyel
force-pushed
the
mkwong/add-target-region-config
branch
from
6db24cb
to
fb8741f
Compare
majisourav99
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary, imperative, start upper case, don't end with a period
Context: Currently with target region push, we push to one colo first then push to the remaining colos. This means that a push job takes 2x the time because we have to wait for the push to the first target colo to succeed first before pushing to the remaining colos concurrently. For phase 2 of target region push, we would like to push to all regions concurrently, but only swap to the new version in the target colo. The target colo will stay on the new version for a specified waitTime and if no errors occur by the end of the waitTiime, we will swap to the new version on the remaining colos. With this approach, push time will not be doubled and it will be the normal push time + waitTime + DVC ingestion time (if enabled)
Change: This pr adds in three store and version configs:
targetSwapRegion,targetSwapRegionWaitTime, andisDavinciHeartbeatReportedto enable target colo push with delayed version swapHow was this PR tested?
Existing ci tests
Does this PR introduce any user-facing changes?