Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build tooling #304

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Update build tooling #304

merged 4 commits into from
Dec 6, 2023

Conversation

alpeb
Copy link
Member

@alpeb alpeb commented Dec 1, 2023

  • Updated rust toolchain to 1.73.0
  • Updated dev container to v42, which also implied:
    • Removed the depguard go lint
    • Removed dupe --no-run flag in justfile
  • Extracted duped meta job into separate composite action
  • Added deny.toml
  • Updated kubert and clap dependencies
  • Moved ./validator/.justfile to ./justfile-rust and made it more generic by introducing the TARGETCRATE env var

This serves as a preliminary to the upcomging
linkerd-reinitialize-pods controller that'll live in this repo as well.

- Updated rust toolchain to 1.73.0
- Updated `dev` container to v42, which also implied:
  - Removed the `depguard` go lint
  - Removed dupe --no-run flag in justfile
- Added `deny.toml`
- Updated kubert and clap dependencies

This serves as a preliminary to the upcomging
`linkerd-reinitialize-pods` controller that'll leave in this repo as
well.
@alpeb alpeb requested a review from a team as a code owner December 1, 2023 14:24
@alpeb alpeb force-pushed the alpeb/build-toolchain-updates branch from 5985185 to 7de17c3 Compare December 1, 2023 22:45
@alpeb alpeb force-pushed the alpeb/build-toolchain-updates branch 3 times, most recently from f79b95e to c1eb58a Compare December 4, 2023 19:47
@alpeb alpeb force-pushed the alpeb/build-toolchain-updates branch from c1eb58a to 39b796d Compare December 4, 2023 19:59
@mateiidavid mateiidavid self-assigned this Dec 6, 2023
Copy link
Member

@mateiidavid mateiidavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

.github/workflows/go.yml Show resolved Hide resolved
justfile-rust Show resolved Hide resolved
@alpeb alpeb merged commit aff2428 into main Dec 6, 2023
28 checks passed
@alpeb alpeb deleted the alpeb/build-toolchain-updates branch December 6, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants