-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement number of HTTP frames metric #3044
base: main
Are you sure you want to change the base?
Conversation
@nerodono, it seems some test can be added to |
…esponses Signed-off-by: Aleksandr Fedotov <nerodono0@gmail.com>
Signed-off-by: Aleksandr Fedotov <nerodono0@gmail.com>
3467567
to
5863a73
Compare
@olix0r, could you look at this PR? |
Thanks for submitting this. There is work in flight (planned to merge soon) that will add route metrics. My preference would be to add this functionality here so that we can include parent/route/backend labels on these metrics. I'll update this PR when that is available. |
Is there any news regarding this? I really don't want to live on a fork =( |
The first version of it has merged but it's not in a place where the frame metrics are really setup. We, coincidentally, had some reports of issues related to applications sending many very small frames, and so I'm planning to introduce a per-route data_size histogram so we can understand both the count of data frames transiting the proxy as well as a rough distribution of their sizes. This work was slightly delayed by some travel, etc. (so please excuse the silence), but it is actively being worked on as of this week. I'll update here when there is something to show. |
It sounds very useful, actually! Which GH issue is related to this work? |
Implements metric described in linkerd/linkerd2#12319