Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate Limiting PoC #3294

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Rate Limiting PoC #3294

wants to merge 1 commit into from

Commits on Oct 23, 2024

  1. Rate Limiting PoC

    Some caveats:
    
    - This doesn't abide yet to the agreed API as declared in linkerd/linkerd2-proxy-api#388 . Instead, this is based on an earlier API proposal using "specifiers" to define the buckets keys.
    - The limiting logic has been added directly into the inbound http policy middleware. It relies on [governor](https://docs.rs/governor/latest/governor/). If we're not allowing to configure bursting in the first implementation, we might reconsider implementing something simpler directly ourselves.
    - There is actually an additional middleware (`RateLimitPolicyService`) that is currently commented out (used in the initial demo), that implemented a simpler approach, inspired by Tower's own rate-limiting middleware.
    alpeb committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    2d4451f View commit details
    Browse the repository at this point in the history