Fix atomics in C++ #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`atomic_int` and `atomic_flag` in C++ are not macros, but typedefs, thus `#ifndef` check fails and C++ users get this macro defined for `atomic_int`: ```c++ `#`define atomic_int std::atomic<int> ``` If then somebody tries to use `atomic_int` with a fully qualified name, i.e. as `std::atomic_int`, they get a cryptic error saying `std in namespace std does not name a type`. Simply importing `atomic_int` and `atomic_flag` into a global namespace fixes the issue, as this means that both uses are legal: * `atomic_int`, which is what used in Event Router * `std::atomic_int`, which might be used in other C++ code.
jd-yolabs
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
atomic_intandatomic_flagin C++ are not macros, but typedefs, thus#ifndefcheck fails and C++ users get this macro defined foratomic_int:`#`define atomic_int std::atomic<int>If then somebody tries to use
atomic_intwith a fully qualified name, i.e. asstd::atomic_int, they get a cryptic error sayingstd in namespace std does not name a type.Simply importing
atomic_intandatomic_flaginto a global namespace fixes the issue, as this means that both uses are legal:atomic_int, which is what used in Event Routerstd::atomic_int, which might be used in other C++ code.