Type-checking container_of macro #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is an error to invoke the container_of() macro with a `ptr` parameter that is not of type pointer-to-`member`. But the macro hides that error by ignoring the 'ptr' type. Make the macro safer by requiring `ptr` to have the correct type. Also, rename it to er_container_of(), to avoid potential name collisions with other container_of() macros.
linkmonitor
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is an error to invoke the container_of() macro with a
ptrparameter that is not of type pointer-to-member. But the macro hides that error by ignoring the 'ptr' type.Make the macro safer by requiring
ptrto have the correct type.Also, rename it to er_container_of(), to avoid potential name collisions with other container_of() macros.