Memory is safe again #148
Open
Memory is safe again #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -77,11 +77,11 @@ private static bool CheckArraysMainPartForEquality(ref char* left, ref char* rig | |||
| { | |||
| while (length >= 10) | |||
| { | |||
| if ((*(int*)left != *(int*)right) | |||
There was a problem hiding this comment.
@uselessgoddess, why did you removed braces? They make code less error prone
There was a problem hiding this comment.
Sorry dear @FreePhoenix888, my ide did this
There was a problem hiding this comment.
But braces make code error prone:)
There was a problem hiding this comment.
uselessgoddess
commented
Aug 13, 2022
Comment on lines
+80
to
+84
| if (*(int*)left != *(int*)right | ||
| || *(int*)(left + 2) != *(int*)(right + 2) | ||
| || *(int*)(left + 4) != *(int*)(right + 4) | ||
| || *(int*)(left + 6) != *(int*)(right + 6) | ||
| || *(int*)(left + 8) != *(int*)(right + 8)) |
There was a problem hiding this comment.
Suggested change
| if (*(int*)left != *(int*)right | |
| || *(int*)(left + 2) != *(int*)(right + 2) | |
| || *(int*)(left + 4) != *(int*)(right + 4) | |
| || *(int*)(left + 6) != *(int*)(right + 6) | |
| || *(int*)(left + 8) != *(int*)(right + 8)) | |
| if ((*(int*)left != *(int*)right | |
| || (*(int*)(left + 2) != *(int*)(right + 2)) | |
| || (*(int*)(left + 4) != *(int*)(right + 4)) | |
| || (*(int*)(left + 6) != *(int*)(right + 6)) | |
| || (*(int*)(left + 8) != *(int*)(right + 8))) |
uselessgoddess
commented
Feb 10, 2023
|
Bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
.Equalsbug from #136