Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix phase #60

Open
wants to merge 1 commit into
base: 7.x-4.x
Choose a base branch
from
Open

Conversation

israelLinnovate
Copy link
Contributor

No description provided.

/.gitk-tmp.11456/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@israelLinnovate @nevos Can you make this more generic? (for example .gitk-tmp*)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although it's not at all relevant to the PR..

@@ -158,7 +158,9 @@ function _ideal_blocks_idea_stats() {

// Hardcode phase for now.
$phase = t('Phase');

if (!empty($entity->field_in_action)){
$phase = $entity->field_in_action["und"][0]["value"];
Copy link
Member

@zohar zohar Sep 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure this string is safe (escaped as necessary)
@Israel123

@@ -158,7 +158,9 @@ function _ideal_blocks_idea_stats() {

// Hardcode phase for now.
$phase = t('Phase');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to have a default Phase, probably through the field's configuration.
For now, change the initial value to "Ideation"
@israelLinnovate

nvelychenko referenced this pull request in istolar/openideal Sep 22, 2020
OI-39: #comment Added condition to check if voted the same user that created the idea.
nvelychenko added a commit that referenced this pull request Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants