feat: add the ability to launch a browser with an http string #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is for #30, right? |
lino-levan
reviewed
Jan 8, 2025
| @@ -136,6 +136,8 @@ const browser = await launch(); | |||
|
|
|||
| // Connect to first browser instead | |||
| const anotherBrowser = await launch({ wsEndpoint: browser.wsEndpoint() }); | |||
| // or simply... | |||
| const anotherBrowser2 = await launch(browser.wsEndpoint()); | |||
There was a problem hiding this comment.
I'm not a fan of this API change. Could we add a endpoint option (with wsEndpoint printing a "this is deprecated use endpoint instead") which supports both http and ws endpoints?
lino-levan
changed the title
|
It's also worth noting that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you can use "launch" to connect to an existing browser by passing either an
http://or aws://stringI've also implemented the old way of doing that as a legacy option - old code will be recognised as wrong by typescript, but it will not break, with a negligible impact on the codebase and on performance