Format Everything (via make format) and MISC Updates to GitHub Workfl…

…ows (#466)

* Format everything (make format)

* Simplified workflow

* Downgrade to Ubuntu 20

* Add upgrade ubuntu comment

.github/workflows/unit-tests.yml

@@ -7,26 +7,23 @@ name: Run Unit test
 
 jobs:
   run-tests:
-    runs-on: ubuntu-latest
+
+    # TODO:
+    # Upgrade back to ubuntu-latest when the permission issue fixed
+    runs-on: ubuntu-20.04
     defaults:
       run:
         working-directory: .ansible/collections/ansible_collections/linode/cloud
     steps:
       - name: checkout repo
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           path: .ansible/collections/ansible_collections/linode/cloud
 
-      - name: update packages
-        run: sudo apt-get update -y
-
-      - name: install make
-        run: sudo apt-get install -y build-essential
-
       - name: setup python 3
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
-          python-version: '3.10'
+          python-version: '3.11'
 
       - name: install dependencies
         run: make deps

Makefile

@@ -14,7 +14,7 @@ clean:
 	rm -f *.tar.gz && rm -rf galaxy.yml
 
 build: deps clean gendocs
-	python scripts/render_galaxy.py $(COLLECTION_VERSION) && ansible-galaxy collection build
+	python3 scripts/render_galaxy.py $(COLLECTION_VERSION) && ansible-galaxy collection build
 
 publish: build
 	@if test "$(GALAXY_TOKEN)" = ""; then \
@@ -56,7 +56,7 @@ gendocs:
 
 	DOCS_PATH=$(DOCS_PATH) ./scripts/specdoc_generate.sh
 	ansible-doc-extractor --template=template/module.rst.j2 $(DOCS_PATH)/inventory plugins/inventory/*.py
-	python scripts/render_readme.py $(COLLECTION_VERSION)
+	python3 scripts/render_readme.py $(COLLECTION_VERSION)
 
 # if want to add all the test add the tag --tags never at the end
 #	ansible-test integration $(TEST_ARGS) --tags never

plugins/module_utils/linode_helper.py

@@ -1,4 +1,5 @@
 """This module contains helper functions for various Linode modules."""
+
 from typing import Any, Callable, Dict, List, Optional, Set, Tuple, Union, cast
 
 import linode_api4

plugins/modules/lke_cluster.py

@@ -478,9 +478,9 @@ def _populate_dashboard_url_no_poll(self, cluster: LKECluster) -> None:
     def _populate_dashboard_url_poll(self, cluster: LKECluster) -> None:
         def condition() -> bool:
             try:
-                self.results[
-                    "dashboard_url"
-                ] = cluster.cluster_dashboard_url_view()
+                self.results["dashboard_url"] = (
+                    cluster.cluster_dashboard_url_view()
+                )
             except ApiError as error:
                 if error.status != 503:
                     raise error