Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Add support for region and type migrations; add migration_type field #443

Conversation

lgarber-akamai
Copy link
Contributor

📝 Description

This PR adds support for running region and type ("resize") migrations on existing instances using the linode.cloud.instance module.

Additionally, this change adds the auto_disk_resize field to allow for automatically resizing implicit disks on type change operations.

Depends on linode/linode_api4-python#340

✔️ How to Test

E2E Testing:

Cross-Region Migration

NOTE: This test currently needs to be run against prod due to availability limitations. Additionally, this test is expected to fail until dev has been merged in linode/linode_api4-python#340.

make TEST_ARGS="-v instance_region_migration" test

Resize Migration

export TEST_API_URL=...
export TEST_API_CA=...
export LINODE_TOKEN=...

make TEST_ARGS="-v instance_type_change" test

Manual Testing

TODO

@lgarber-akamai lgarber-akamai requested a review from a team as a code owner November 28, 2023 19:25
@lgarber-akamai lgarber-akamai requested review from ykim-akamai and yec-akamai and removed request for a team November 28, 2023 19:25
Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Everything worked as expected locally

@lgarber-akamai lgarber-akamai merged commit 8752e5d into linode:proj/unified-migrations Dec 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants