Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Add account_availability_info module #445

Merged
merged 8 commits into from
Dec 13, 2023

Conversation

yec-akamai
Copy link
Contributor

📝 Description

Add the account_availability_info module for user to get information about resource availability in a region to their account.

✔️ How to Test

To run the test, you'll need to install python sdk from proj/dc-get-well branch, and test it in Alpha.

make TEST_ARGS="-v account_availability_info" test

Manual test:

  1. Inside of a collection sandbox environment (e.g. dx-devenv), run the following playbook:
- name: ansible_linode Sandbox Playbook
  hosts: localhost
  tasks:
    - name: Get account availability information
      linode.cloud.account_availability_info:
        region: us-east
      register: account_availability

    - name: Output info about the accout availability
      debug:
        msg: |
          Account Availability Info:
            Region: {{ account_availability.account_availability.region }}
            Unavailable: {{ account_availability.account_availability.unavailable }}

@yec-akamai yec-akamai requested a review from a team as a code owner December 8, 2023 21:04
@yec-akamai yec-akamai requested review from zliang-akamai and ykim-akamai and removed request for a team December 8, 2023 21:04
@ykim-akamai
Copy link
Contributor

ykim-akamai commented Dec 11, 2023

Looks good. Couldn't pass the tests locally due to error was: ImportError: cannot import name 'AccountAvailability . Can you add test result as comment once Python SDK has the changes?

@zliang-akamai
Copy link
Member

Can you run make gendocs and upload the generated docs?

Copy link
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, and tests passed. Well done!

@yec-akamai yec-akamai merged commit 8380945 into proj/dc-get-well Dec 13, 2023
7 checks passed
@yec-akamai yec-akamai deleted the TPT-2456/account-availability-module branch December 13, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants