ref: Migrate object_cluster_list module to ListModule base class; add deprecation support to ListModule and InfoModule #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgarber-akamai
added
the
improvement
lgarber-akamai
commented
Aug 22, 2024
| @@ -10,18 +10,6 @@ | |||
| # - assert: | |||
| # that: | |||
| # - no_filter.clusters | length >= 1 | |||
| # | |||
| # - name: List regions with filter on region | |||
There was a problem hiding this comment.
This no longer filters as expected in both the old and new module implementations. Given this is a deprecated API, do we think it's worth keeping and investigating further?
There was a problem hiding this comment.
I think we can skip and save effort since it's deprecated.
There was a problem hiding this comment.
Sounds good to me!
lgarber-akamai
requested review from
jriddle-linode and
yec-akamai
and removed request for
a team
yec-akamai
approved these changes
Aug 27, 2024
| @@ -10,18 +10,6 @@ | |||
| # - assert: | |||
| # that: | |||
| # - no_filter.clusters | length >= 1 | |||
| # | |||
| # - name: List regions with filter on region | |||
There was a problem hiding this comment.
I think we can skip and save effort since it's deprecated.
jriddle-linode
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request migrates the
object_cluster_listmodule over to the ListModule base class. Because this module is deprecated, this PR also adds support for deprecating modules using the ListModule and InfoModule base classes.NOTE: object_cluster_info was intentionally not migrated as a part of this PR because its usage deviates too much from InfoModule.
✔️ How to Test
The following test steps assume you have pulled down this PR locally and run
make install.Integration Testing
tests/integration/targets/object_cluster_list/main.yaml, remove the debug task and uncomment the rest of the playbook.