-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented changes for Linode Disk Encryption (re-merge) #582
Merged
ezilber-akamai
merged 21 commits into
linode:dev
from
ezilber-akamai:TPT-2890-lde-changes
Sep 11, 2024
Merged
Implemented changes for Linode Disk Encryption (re-merge) #582
ezilber-akamai
merged 21 commits into
linode:dev
from
ezilber-akamai:TPT-2890-lde-changes
Sep 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezilber-akamai
requested review from
zliang-akamai and
yec-akamai
and removed request for
a team
August 28, 2024 14:26
ezilber-akamai
added
do-not-merge
PRs that should not be merged until the commented issue is resolved
new-feature
for new features in the changelog.
labels
Aug 28, 2024
ezilber-akamai
removed
the
do-not-merge
PRs that should not be merged until the commented issue is resolved
label
Sep 5, 2024
zliang-akamai
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tests passed, nice work!
yec-akamai
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Updated ansible modules to consume changes according to the API Spec (can be found in the ticket).
✔️ How to Test
Integration Tests
make TEST_ARGS="-v instance_disk_encryption" test
make TEST_ARGS="-v lke_cluster_basic" test
make TEST_ARGS="-v lke_node_pool_basic" test