Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented changes for Linode Disk Encryption (re-merge) #582

Merged
merged 21 commits into from
Sep 11, 2024

Conversation

ezilber-akamai
Copy link
Contributor

📝 Description

Updated ansible modules to consume changes according to the API Spec (can be found in the ticket).

✔️ How to Test

Integration Tests

  • make TEST_ARGS="-v instance_disk_encryption" test
  • make TEST_ARGS="-v lke_cluster_basic" test
  • make TEST_ARGS="-v lke_node_pool_basic" test

@ezilber-akamai ezilber-akamai requested a review from a team as a code owner August 28, 2024 14:26
@ezilber-akamai ezilber-akamai requested review from zliang-akamai and yec-akamai and removed request for a team August 28, 2024 14:26
@ezilber-akamai ezilber-akamai added do-not-merge PRs that should not be merged until the commented issue is resolved new-feature for new features in the changelog. labels Aug 28, 2024
@ezilber-akamai ezilber-akamai removed the do-not-merge PRs that should not be merged until the commented issue is resolved label Sep 5, 2024
Copy link
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests passed, nice work!

@ezilber-akamai ezilber-akamai merged commit 1da8e49 into linode:dev Sep 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature for new features in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants