Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding encryption support for Volumes #611

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

jriddle-linode
Copy link
Collaborator

📝 Description

What does this PR do and why is this change necessary?

Add support for capabilities and encryption to GET linode and POST volume respectively.

✔️ How to Test

How do I run the relevant unit/integration tests?

make TEST_ARGS="volume_basic" test
make TEST_ARGS="instance_basic" test

@jriddle-linode jriddle-linode requested a review from a team as a code owner October 28, 2024 15:24
@jriddle-linode jriddle-linode requested review from lgarber-akamai and yec-akamai and removed request for a team October 28, 2024 15:24
@jriddle-linode jriddle-linode added the improvement for improvements in existing functionality in the changelog. label Oct 28, 2024
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing locally with Block Storage Disk Encryption enabled on my account, nice work!

@ykim-akamai ykim-akamai self-requested a review October 29, 2024 15:13
Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests are passing locally. Nice work!

@jriddle-linode jriddle-linode merged commit c670322 into linode:dev Oct 29, 2024
5 checks passed
@yec-akamai yec-akamai added new-feature for new features in the changelog. and removed improvement for improvements in existing functionality in the changelog. labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature for new features in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants