-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: Support IP module to allocate a new IP #628
Conversation
Makefile
Outdated
@@ -91,7 +91,7 @@ delete-e2e-firewall: update-test-submodules | |||
echo "$$OUTPUT"; \ | |||
exit 1; \ | |||
else \ | |||
echo "E2E Cloud firewall created successfully."; \ | |||
echo "E2E Cloud firewall deleted successfully."; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick
"The type of address you are requesting. " | ||
"Only IPv4 addresses may be allocated through this operation." | ||
], | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could a state
attribute be added here to support creating/deleting IPs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find delete IP is not properly implemented in python sdk. We can't use the delete() function from Base because the endpoint is not correct. I'll create a python-sdk ticket to implement the right endpoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and tests are passing on my end!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tests passing locally
📝 Description
Support a new linode.cloud.ip module to allocate a new IP to a Linode instance.
✔️ How to Test
Integration test:
Manual test: