[improvement] adding verified clients for validation webhooks #520
+690
−198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To create verified linodeclients for validation webhooks, we need to have CredRef api tokens for various resources.
This PR tries to create verified clients if the CredRef is set on a particular resource.
To use the K8s client in the validation webhooks, this PR setups up the webhook like
func (r *LinodeCluster) SetupWebhookWithManager(mgr ctrl.Manager) error { return ctrl.NewWebhookManagedBy(mgr). For(r). WithValidator(&linodeClusterValidator{Client: mgr.GetClient()}). Complete() }
instead of the approach used previously where the resource itself extends the var _ webhook.Validator = &LinodeCluster{}
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
All the testcase suites have been updated to use these Validators instead.
Special notes for your reviewer:
TODOs: