dep: Use GitLab-maintained docker-machine package #145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request adds a replace statement to
go.mod
to use GitLab's docker-machine fork rather than its deprecated equivalent.This is necessary to consume versions of Docker > v20.x.x which contain critical security fixes.
NOTE: This has been successfully tested against v2.8.5 using the steps in the Testing Rancher Compatibility section.
✔️ How to Test
The following test steps assume you have pulled down this PR locally.
Unit Testing
make test
Manual Testing
Ensure the
LINODE_TOKEN
environment variable is exported.Install
docker-machine-driver-linode
locally:curl -o docker-machine "https://gitlab-docker-machine-downloads.s3.amazonaws.com/v0.16.2-gitlab.19/docker-machine-Darwin-x86_64" chmod +x docker-machine
NOTE: Be sure to download the correct binary for your system.
Testing Rancher Compatibility
NOTE: This should be done in a secure dev VM with restricted access to ports 22, 80 and 443. All other ports must be open to enable connectivity between nodes and the deployed Rancher instance. See the
development-instance
tool in dx-devenv for more detailsPrerequisites:
docker-machine-driver-linode
:docker-machine-driver-linode
:# NOTE: cgo must be disabled because the Rancher container does not support glibc. CGO_ENABLED=0 make build
docker-machine-driver-linode
binary into the running Rancher container: