improve uvc with import/export of config parameters #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the one of the supported formats is missing in the configfs layout, currently the export function will run into an error. We fix it by just passing 0 if the format is missing to keep on parsing. Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
|
"variale" in the second commit message and "paraemters" in the third
commit message seem like typos.
Please also compare results for cppcheck, scan-build and GCC -fanalyzer
static analysis runs before and after the commits.
Otherwise this looks good to me, please merge.
…--
bye,
pabs
https://bonedaddy.net/pabs3/
|
The return value of scandir is used in init_frames to iterate over the elements. The iteration is done over nmb not ret. So this patch is fixing this to fill the right variable. Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
The functions config parameters like maxburst, maxpacket, interval and function_name are possible to be set by scheme file as well. This patch adds support to import and export these variables. Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
|
I fixed the commit typos. But, from your earlier post: "Please also compare results for cppcheck, scan-build and GCC -fanalyzer Is there some automatic way to do that? |
|
I don't think there is a way to automate the comparison between results
for branches. I usually just run them against master saving results to
a file, checkout the branch, run them again saving results to a file
and then compare them with diff or meld. For GCC -fanalyzer I think you
just need to do a build with -fanalyzer in the CFLAGS.
These are the commands:
```
$ cppcheck -j1 --quiet .
$ cppcheck -j1 --quiet --enable=warning .
$ cppcheck -j1 --quiet --enable=all .
$ cppcheck -j1 --quiet --enable=all --force .
```
```
$ scan-build make
```
```
make CFLAGS=-fanalyzer
```
…--
bye,
pabs
https://bonedaddy.net/pabs3/
|
|
@mgrzeschik in #47 it was proposed to make a new release, do you want to finish including this PR before we do that, or wait until after the release to do that? |
|
AFAIAC having this PR in the new release would be great! Thanks a lot in advance :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.