Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "chore: Reimplement notification animation" #715

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Revert "chore: Reimplement notification animation" #715

wants to merge 1 commit into from

Conversation

yixinshark
Copy link
Contributor

This reverts commit 2f8de93

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yixinshark

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 21, 2024 •
edited
Loading

TAG Bot

TAG: 0.0.43
EXISTED: no
DISTRIBUTION: unstable

@yixinshark
Copy link
Contributor Author

/topic shell-vectory-20240821

@deepin-ci-robot
Copy link

Add topic: shell-vectory-20240821 successed.

@yixinshark
Copy link
Contributor Author

41临时版本，此代码不必合并，下次打changlelog需要带上41的changelog修改内容。

@yixinshark
Copy link
Contributor Author

/integr-topic shell-vectory-20240821

@deepin-ci-robot deepin-ci-robot mentioned this pull request Aug 21, 2024
Open
@deepin-ci-robot
Copy link

Integrated with pr deepin-community/Repository-Integration#1908

@deepin-bot
Copy link

deepin-bot bot commented Aug 29, 2024

TAG Bot

New tag: 0.0.42
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #718

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在BeatAnimation的onStopped和onFinished槽函数中，root.target.scale = baseScale可能会导致无限循环，因为scale属性在动画完成后被设置为baseScale，而baseScale在动画开始时被设置。如果baseScale在动画过程中发生变化，那么这个赋值操作可能会导致动画无限循环进行。
  • BeatAnimation的动画序列可能需要调整以避免重复的scale值，例如通过添加一个循环动画来改变scale的值。
  • BeatAnimation的PropertyAnimation可能需要优化以避免不必要的重复计算，例如通过预计算动画的值来减少重复的计算。
  • BeatAnimation的onStopped和onFinished槽函数中的loops设置为Animation.Infinite可能会导致无限循环，应该根据实际需求设置合理的循环次数。

是否建议立即修改:
是

@yixinshark
Copy link
Contributor Author

/topic shell-vectory-20240828

@deepin-ci-robot
Copy link

Add topic: shell-vectory-20240828 successed.

@yixinshark
Copy link
Contributor Author

/integr-topic shell-vectory-20240828

@deepin-ci-robot
Copy link

Integrated with pr deepin-community/Repository-Integration#1945

@deepin-bot
Copy link

deepin-bot bot commented Aug 29, 2024

TAG Bot

New tag: 0.0.43
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #727

@deepin-bot
Copy link

deepin-bot bot commented Oct 31, 2024

TAG Bot

New tag: 1.99.3
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #846

@deepin-bot
Copy link

deepin-bot bot commented Nov 7, 2024

TAG Bot

New tag: 1.99.4
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
shell-vectory-20240828
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yixinshark @deepin-ci-robot