panel.js: Only pick reactive actors on validating right click target #12403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anaximeno
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to fix linuxmint/cinnamon-spices-extensions#749 for the extension mouse-click-effects.
The extension allows the user to put an icon below its cursor pointer to perform animations or follow the cursor pointer.
I use a St.Icon with the reactive attribute set to false but still it is interfering when right-clicking the panel to open the panel menu, though this does not happen when right-clicking an applet to open the applet menu.
When receiving a right-click event the panel verifies if the click target was indeed the panel directly or another component before showing the menu (I suppose to avoid opening when right-clicking applets), for that, it will pick the actor in the position of the click, but even though the St.Icon I have it is unreactive it's being picked unnecessarily, with this PR I changed it only to pick REACTIVE actors, preventing non-reactive actors from being considered in this process.