Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set http2 at http level #167

Merged
merged 3 commits into from
May 29, 2024
Merged

Set http2 at http level #167

merged 3 commits into from
May 29, 2024

Conversation

thespad
Copy link
Member

@thespad thespad commented May 28, 2024

linuxserver.io

  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

@thespad thespad requested a review from a team May 28, 2024 19:12
@thespad thespad self-assigned this May 28, 2024
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/baseimage-nginx/3.20-1.26.0-r2_8.3.7-r0-pkg-be2dad43-dev-f2fd72f70b9e8d39457f906d8a46502a1cb54a11-pr-167/index.html
https://ci-tests.linuxserver.io/lspipepr/baseimage-nginx/3.20-1.26.0-r2_8.3.7-r0-pkg-be2dad43-dev-f2fd72f70b9e8d39457f906d8a46502a1cb54a11-pr-167/shellcheck-result.xml

Tag Passed
amd64-3.20-1.26.0-r2_8.3.7-r0-pkg-be2dad43-dev-f2fd72f70b9e8d39457f906d8a46502a1cb54a11-pr-167 ✅
arm64v8-3.20-1.26.0-r2_8.3.7-r0-pkg-be2dad43-dev-f2fd72f70b9e8d39457f906d8a46502a1cb54a11-pr-167 ✅

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/baseimage-nginx/3.20-1.26.0-r2_8.3.7-r0-pkg-be2dad43-dev-ac94518f9971e777c46042f97dc600c604a971cb-pr-167/index.html
https://ci-tests.linuxserver.io/lspipepr/baseimage-nginx/3.20-1.26.0-r2_8.3.7-r0-pkg-be2dad43-dev-ac94518f9971e777c46042f97dc600c604a971cb-pr-167/shellcheck-result.xml

Tag Passed
amd64-3.20-1.26.0-r2_8.3.7-r0-pkg-be2dad43-dev-ac94518f9971e777c46042f97dc600c604a971cb-pr-167 ✅
arm64v8-3.20-1.26.0-r2_8.3.7-r0-pkg-be2dad43-dev-ac94518f9971e777c46042f97dc600c604a971cb-pr-167 ✅

nemchik
nemchik requested changes May 29, 2024
View reviewed changes
Copy link
Member

@nemchik nemchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just caught this
The only difference upstream is a comment line if we want to adjust that https://git.alpinelinux.org/aports/tree/main/nginx/nginx.conf?h=3.20-stable#n34

root/defaults/nginx/nginx.conf.sample Outdated Show resolved Hide resolved
@thespad @nemchik
Update source comment
1a5ef52 
Co-authored-by: Eric Nemchik <eric@nemchik.com>
@thespad thespad requested a review from nemchik May 29, 2024 12:57
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/baseimage-nginx/3.20-1.26.0-r2_8.3.7-r0-pkg-be2dad43-dev-1a5ef52d44aa95d376f6e85b798add62d4ee038a-pr-167/index.html
https://ci-tests.linuxserver.io/lspipepr/baseimage-nginx/3.20-1.26.0-r2_8.3.7-r0-pkg-be2dad43-dev-1a5ef52d44aa95d376f6e85b798add62d4ee038a-pr-167/shellcheck-result.xml

Tag Passed
amd64-3.20-1.26.0-r2_8.3.7-r0-pkg-be2dad43-dev-1a5ef52d44aa95d376f6e85b798add62d4ee038a-pr-167 ✅
arm64v8-3.20-1.26.0-r2_8.3.7-r0-pkg-be2dad43-dev-1a5ef52d44aa95d376f6e85b798add62d4ee038a-pr-167 ✅

@thespad thespad merged commit 450eaed into master May 29, 2024
5 checks passed
@thespad thespad deleted the http2-confs branch May 29, 2024 13:17
nemchik added a commit to linuxserver/reverse-proxy-confs that referenced this pull request May 29, 2024
@nemchik
Set http2 at http level
4f72dd5 
Ref: linuxserver/docker-baseimage-alpine-nginx#167

Signed-off-by: Eric Nemchik <eric@nemchik.com>
@nemchik nemchik mentioned this pull request May 29, 2024
Merged
owine added a commit to owine/docker-mods that referenced this pull request Jul 31, 2024
@owine
fix(swag-dashboard): remove deprecated http2 listen
5b20a7b 
linuxserver/docker-baseimage-alpine-nginx#167

Signed-off-by: owine <owine@users.noreply.github.com>
@owine owine mentioned this pull request Jul 31, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quietsy quietsy quietsy approved these changes

@nemchik nemchik nemchik approved these changes

Assignees

@thespad thespad

Labels
None yet
Projects
Issue & PR Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thespad @LinuxServer-CI @nemchik @quietsy