-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Install Slurpit Plugin for netbox) #944
feat(Install Slurpit Plugin for netbox) #944
Conversation
PR build pushed to |
root/etc/s6-overlay/s6-rc.d/init-mod-netbox-slurpit-install/run
Outdated
Show resolved
Hide resolved
PR build pushed to |
PR build pushed to |
PR build pushed to |
PR build pushed to |
PR build pushed to |
PR build pushed to |
root/etc/s6-overlay/s6-rc.d/init-mod-netbox-slurpit-install/run
Outdated
Show resolved
Hide resolved
PR build pushed to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the mod's init has to be a dependency for init-mod-package-install
instead of init-mods-end
so that it runs before the package install script and not after or concurrently
PR build pushed to |
PR build pushed to |
Looks good, thanks. Please test the mod |
PR build pushed to |
Unfortunately, I am not having any luck. It is as if the mod is not being executed at all. compose.yml
output
|
Ah, the issue is, netbox's init actually runs some of netbox scripts and it runs before the mods. So your config references the plugin, but it's not installed yet. |
May have to modify netbox's init to move the migration to the service file instead. I'll have to discuss with the team internally. |
Alright. Given that I will hold on further development on this PR until further notice. Thanks for all your help so far. |
Can you test this netbox image with the mod builds from here? |
Not completely clean on start, but it is functional now.
Now in the netbox UI I can see Slurpit in the navigation menu and adjust settings and such. Thanks again for your help on this. |
Can you try this one? Thanks |
That one gives a clean startup like I was expecting
compose.yml for reference
|
Perfect, thanks. |
Install the Slurpit Plugin for netbox
Description:
This will allow for the
slurpit_netbox
python Package to be installed. Once running this a user can update the Plugins section of theirconfiguration.py
to include this Plugin.Benefits of this PR and context:
Currently their are no Docker Mods available for netbox and this is a starting point for others to add plugin installation support for netbox.
How Has This Been Tested?
Unsure how to test this without restarting the container and losing the installation of the package.
Source / References:
Official Slurpit Repository
Netbox supported plugins