Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenWRT instructions in readme-vars.yml #63

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

dezeroku
Copy link
Contributor

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Update the OpenWRT setup instructions, so not only the last dhcp-boot/dhcp-match pair is applied.

Benefits of this PR and context:

Resolves #62

How Has This Been Tested?

Works fine in my OpenWRT setup, booting from a VM and a "physical" device.

Source / References:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@thelamer thelamer requested a review from a team January 31, 2024 01:49
@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/netbootxyz/0.7.0-pkg-4d113da0-dev-2cf6287e98bb93c97c21b198eadbb9d0ed1dd636-pr-63/index.html
https://ci-tests.linuxserver.io/lspipepr/netbootxyz/0.7.0-pkg-4d113da0-dev-2cf6287e98bb93c97c21b198eadbb9d0ed1dd636-pr-63/shellcheck-result.xml

Tag Passed
amd64-0.7.0-pkg-4d113da0-dev-2cf6287e98bb93c97c21b198eadbb9d0ed1dd636-pr-63
arm64v8-0.7.0-pkg-4d113da0-dev-2cf6287e98bb93c97c21b198eadbb9d0ed1dd636-pr-63

@drizuid
Copy link
Member

drizuid commented Jan 31, 2024

if we're not going to use uci, may as well delete the section and list wrt along with the other dnsmasq section since it's just a repeat

@dezeroku
Copy link
Contributor Author

Good call, I'll change it.

Do you think it's a good idea to add a pointer that dnsmasq service likely needs to be restarted for the changes to take effect? I'd expect this to be true for most systems, not only OpenWRT

@drizuid
Copy link
Member

drizuid commented Jan 31, 2024

Good call, I'll change it.

Do you think it's a good idea to add a pointer that dnsmasq service likely needs to be restarted for the changes to take effect? I'd expect this to be true for most systems, not only OpenWRT

yes, the restart is definitely a good call and will complement the section nicely

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/netbootxyz/0.7.0-pkg-4d113da0-dev-6bf5dd43e924f812ba9d064b3916861416373d47-pr-63/index.html
https://ci-tests.linuxserver.io/lspipepr/netbootxyz/0.7.0-pkg-4d113da0-dev-6bf5dd43e924f812ba9d064b3916861416373d47-pr-63/shellcheck-result.xml

Tag Passed
amd64-0.7.0-pkg-4d113da0-dev-6bf5dd43e924f812ba9d064b3916861416373d47-pr-63
arm64v8-0.7.0-pkg-4d113da0-dev-6bf5dd43e924f812ba9d064b3916861416373d47-pr-63

Copy link
Member

@drizuid drizuid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you were going to keep the note regarding dnsmasq restart, right? I would not put /etc/init.d/dnsmasq restart, but rather something along the lines of "Ensure you restart your DNSMASQ service after the changes."

@dezeroku
Copy link
Contributor Author

Yup, I wanted to wait for your comment and didn't see it earlier, sorry about that. Added the note now

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/netbootxyz/0.7.0-pkg-4d113da0-dev-87ace2895ad015ed5d2c87cdaffa3ef1f86d6471-pr-63/index.html
https://ci-tests.linuxserver.io/lspipepr/netbootxyz/0.7.0-pkg-4d113da0-dev-87ace2895ad015ed5d2c87cdaffa3ef1f86d6471-pr-63/shellcheck-result.xml

Tag Passed
amd64-0.7.0-pkg-4d113da0-dev-87ace2895ad015ed5d2c87cdaffa3ef1f86d6471-pr-63
arm64v8-0.7.0-pkg-4d113da0-dev-87ace2895ad015ed5d2c87cdaffa3ef1f86d6471-pr-63

@drizuid drizuid merged commit b4c1bc3 into linuxserver:master Jan 31, 2024
3 checks passed
@dezeroku dezeroku deleted the to-upstream branch January 31, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] documentation update for OpenWRT.
4 participants