Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to reload the configuration #160

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

DeflateAwning
Copy link
Contributor

Fixes #131. Instructions came from this comment in #131.

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r2-pkg-8c701655-dev-caa880f8457304c793c1f95759f211694831c833-pr-160/index.html
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r2-pkg-8c701655-dev-caa880f8457304c793c1f95759f211694831c833-pr-160/shellcheck-result.xml

Tag Passed
amd64-2.8.2-r2-pkg-8c701655-dev-caa880f8457304c793c1f95759f211694831c833-pr-160
arm64v8-2.8.2-r2-pkg-8c701655-dev-caa880f8457304c793c1f95759f211694831c833-pr-160

@DeflateAwning
Copy link
Contributor Author

Don't merge quite yet; still figuring out the best way to do this actually. The way in this PR is sub-optimal.

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r2-pkg-8c701655-dev-8bea3d1ad908e4aac3803d357399f91134311109-pr-160/index.html
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r2-pkg-8c701655-dev-8bea3d1ad908e4aac3803d357399f91134311109-pr-160/shellcheck-result.xml

Tag Passed
amd64-2.8.2-r2-pkg-8c701655-dev-8bea3d1ad908e4aac3803d357399f91134311109-pr-160
arm64v8-2.8.2-r2-pkg-8c701655-dev-8bea3d1ad908e4aac3803d357399f91134311109-pr-160

@DeflateAwning
Copy link
Contributor Author

Confirmed that this current method is good to merge to main/master! Hopefully somone can review it!

@thespad
Copy link
Member

thespad commented Nov 11, 2023

Please replace $CID with smokeping (you can leave the note about replacing it with the name of your container), because 90% of our users will both use the default name and blindly copy/paste whatever is written in the readme.

Otherwise I'm happy to merge it.

@DeflateAwning
Copy link
Contributor Author

FIxed! Changed $CID to smokeping.

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r2-pkg-8c701655-dev-931e521a830680bef8509681ad6f2c0ffe797b87-pr-160/index.html
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r2-pkg-8c701655-dev-931e521a830680bef8509681ad6f2c0ffe797b87-pr-160/shellcheck-result.xml

Tag Passed
amd64-2.8.2-r2-pkg-8c701655-dev-931e521a830680bef8509681ad6f2c0ffe797b87-pr-160
arm64v8-2.8.2-r2-pkg-8c701655-dev-931e521a830680bef8509681ad6f2c0ffe797b87-pr-160

@thespad thespad merged commit 11fccfb into linuxserver:master Nov 13, 2023
2 checks passed
@DeflateAwning DeflateAwning deleted the docs-readme-reload-config branch November 13, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Doc Request: add instructions on how to reload the configuration
3 participants