-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration for running smokeping in slave mode #170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this pull request! Be sure to follow the pull request template!
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
c8c9a67
to
aae8f65
Compare
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changelog entry to the readme and then I'm happy to merge this
@thespad I updated the changelog, I appreciate you getting back to me on this. |
I am a bot, here are the test results for this PR:
|
Description:
This change adds configuration (via environment variables) that allows for smokeping to be run in slave mode.
Benefits of this PR and context:
Running smokeping in slave mode has its advantages, as you can define configuration that is the source-of-truth on the master host, and replicate it across different machines throughout your network. This can help tease out latency issues that may be unique to certain segments of the network.
How Has This Been Tested?
This has been tested locally on my network. I built and ran the docker image locally on my slave host (raspberry pi 4b running on ubuntu server 22.04). Everything works as expected.
You just need to modify the slaves, targets, and slavessecrets file on the master host, per the documentation.
Source / References: