Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for running smokeping in slave mode #170

Merged
merged 6 commits into from
Mar 22, 2024

Conversation

jkossis
Copy link

@jkossis jkossis commented Mar 1, 2024

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

This change adds configuration (via environment variables) that allows for smokeping to be run in slave mode.

Benefits of this PR and context:

Running smokeping in slave mode has its advantages, as you can define configuration that is the source-of-truth on the master host, and replicate it across different machines throughout your network. This can help tease out latency issues that may be unique to certain segments of the network.

How Has This Been Tested?

This has been tested locally on my network. I built and ran the docker image locally on my slave host (raspberry pi 4b running on ubuntu server 22.04). Everything works as expected.

You just need to modify the slaves, targets, and slavessecrets file on the master host, per the documentation.

Source / References:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-5477ff02-dev-7bfc188469a7fcadc1ad81a771e55f9e5f744e23-pr-170/index.html
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-5477ff02-dev-7bfc188469a7fcadc1ad81a771e55f9e5f744e23-pr-170/shellcheck-result.xml

Tag Passed
amd64-2.8.2-r3-pkg-5477ff02-dev-7bfc188469a7fcadc1ad81a771e55f9e5f744e23-pr-170
arm64v8-2.8.2-r3-pkg-5477ff02-dev-7bfc188469a7fcadc1ad81a771e55f9e5f744e23-pr-170

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-5477ff02-dev-cdc76873b9413f585121e454bd998ea3a6731e6a-pr-170/index.html
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-5477ff02-dev-cdc76873b9413f585121e454bd998ea3a6731e6a-pr-170/shellcheck-result.xml

Tag Passed
amd64-2.8.2-r3-pkg-5477ff02-dev-cdc76873b9413f585121e454bd998ea3a6731e6a-pr-170
arm64v8-2.8.2-r3-pkg-5477ff02-dev-cdc76873b9413f585121e454bd998ea3a6731e6a-pr-170

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-5477ff02-dev-aae8f6505ce69e117a2e983bd51ac74ba6f4d922-pr-170/index.html
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-5477ff02-dev-aae8f6505ce69e117a2e983bd51ac74ba6f4d922-pr-170/shellcheck-result.xml

Tag Passed
amd64-2.8.2-r3-pkg-5477ff02-dev-aae8f6505ce69e117a2e983bd51ac74ba6f4d922-pr-170
arm64v8-2.8.2-r3-pkg-5477ff02-dev-aae8f6505ce69e117a2e983bd51ac74ba6f4d922-pr-170

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-5477ff02-dev-0adb3400bb0461030ff3e1e98f07cee1bbe18cf9-pr-170/index.html
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-5477ff02-dev-0adb3400bb0461030ff3e1e98f07cee1bbe18cf9-pr-170/shellcheck-result.xml

Tag Passed
amd64-2.8.2-r3-pkg-5477ff02-dev-0adb3400bb0461030ff3e1e98f07cee1bbe18cf9-pr-170
arm64v8-2.8.2-r3-pkg-5477ff02-dev-0adb3400bb0461030ff3e1e98f07cee1bbe18cf9-pr-170

@jkossis
Copy link
Author

jkossis commented Mar 2, 2024

@thespad @thelamer any chance I could get a review on this? 🙂

Copy link
Member

@thespad thespad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry to the readme and then I'm happy to merge this

@jkossis
Copy link
Author

jkossis commented Mar 22, 2024

@thespad I updated the changelog, I appreciate you getting back to me on this.

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-c4afba77-dev-8baba958c68a1f83fbbe15e66f40eb4af7d94c7e-pr-170/index.html
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-c4afba77-dev-8baba958c68a1f83fbbe15e66f40eb4af7d94c7e-pr-170/shellcheck-result.xml

Tag Passed
amd64-2.8.2-r3-pkg-c4afba77-dev-8baba958c68a1f83fbbe15e66f40eb4af7d94c7e-pr-170
arm64v8-2.8.2-r3-pkg-c4afba77-dev-8baba958c68a1f83fbbe15e66f40eb4af7d94c7e-pr-170

@thespad thespad merged commit da61e11 into linuxserver:master Mar 22, 2024
4 checks passed
@jkossis jkossis deleted the add-slave-config branch March 23, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants