Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update to Node.js 22 TDE-1193 #152

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

build: update to Node.js 22 TDE-1193 #152

wants to merge 1 commit into from

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Jun 20, 2024 •
edited
Loading

  1. Update the engine:

    jq '.engines.node = "^22.11.0"' package.json | sponge package.json

  2. Update the uses of linz/action-typescript:

    for path in .github/workflows/*.y*ml; do
    yq --inplace '(.jobs.*.steps[] | select(.uses == "linz/action-typescript*").with.node-version) = "22.x"' "$path"
done

  3. Verify the change:

    git clean -fdx --exclude=.idea
npm install
npm run build
npm run test
npm run lint
git grep --word-regexp -e 14 -e 16 -e 18 -e 20

@l0b0
build: update to Node.js 22 TDE-1193
61b9ecb 
1. Update the engine:

   ```
   jq '.engines.node = "^22.2.0"' package.json | sponge package.json
   ```
2. Update the lock file:

   ```
   npm install
   ```
3. Update the uses of `linz/action-typescript`:

   ```
   for path in .github/workflows/*.y*ml; do
       yq --inplace '(.jobs.*.steps[] | select(.uses == "linz/action-typescript*").with.node-version) = "22.x"' "$path"
   done
   ```

Verified with `git grep --word-regexp -e 14 -e 16 -e 18 -e 20`.
@l0b0 l0b0 requested a review from a team as a code owner June 20, 2024 22:51
@l0b0 l0b0 requested review from blacha, amfage, MDavidson17 and paulfouquet and removed request for a team June 20, 2024 22:51
@l0b0 l0b0 enabled auto-merge June 20, 2024 22:51
@l0b0 l0b0 marked this pull request as draft September 6, 2024 04:03
auto-merge was automatically disabled September 6, 2024 04:03

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blacha blacha Awaiting requested review from blacha blacha is a code owner automatically assigned from linz/li-topo-data-engineering

@amfage amfage Awaiting requested review from amfage amfage is a code owner automatically assigned from linz/li-topo-data-engineering

@MDavidson17 MDavidson17 Awaiting requested review from MDavidson17 MDavidson17 is a code owner automatically assigned from linz/li-topo-data-engineering

@paulfouquet paulfouquet Awaiting requested review from paulfouquet paulfouquet is a code owner automatically assigned from linz/li-topo-data-engineering

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@l0b0