Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7275] adds cache for api endpoints #5256

Closed
wants to merge 5 commits into from
Closed

[7275] adds cache for api endpoints #5256

wants to merge 5 commits into from

Conversation

hklarner
Copy link
Contributor

@hklarner hklarner commented Oct 2, 2023

No description provided.

@hklarner hklarner requested review from goapunk and m4ra October 2, 2023 14:46
@hklarner hklarner force-pushed the hk-2023-10-api-caching branch 3 times, most recently from 05b9844 to 6bca385 Compare October 2, 2023 15:06
m4ra
m4ra requested changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@m4ra m4ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very good overall

meinberlin/apps/bplan/api.py Outdated Show resolved Hide resolved
meinberlin/apps/bplan/signals.py Outdated Show resolved Hide resolved
meinberlin/apps/cache_helpers.py Outdated Show resolved Hide resolved
meinberlin/apps/extprojects/api.py Outdated Show resolved Hide resolved
meinberlin/apps/cache_helpers.py Outdated Show resolved Hide resolved
meinberlin/apps/projectcontainers/api.py Outdated Show resolved Hide resolved
meinberlin/apps/projectcontainers/api.py Outdated Show resolved Hide resolved
meinberlin/apps/projects/api.py Outdated Show resolved Hide resolved
meinberlin/apps/projects/api.py Outdated Show resolved Hide resolved
meinberlin/config/settings/production.py Show resolved Hide resolved
goapunk
goapunk requested changes Oct 4, 2023
View reviewed changes
meinberlin/apps/cache_helpers.py Outdated Show resolved Hide resolved
meinberlin/apps/cache_helpers.py Outdated Show resolved Hide resolved
meinberlin/apps/projects/api.py Outdated Show resolved Hide resolved
@hklarner hklarner force-pushed the hk-2023-10-api-caching branch from 6bca385 to bc339f4 Compare October 4, 2023 09:12
@hklarner hklarner force-pushed the hk-2023-10-api-caching branch 2 times, most recently from e3dbc32 to 6f3ca5b Compare October 4, 2023 14:24
@hklarner hklarner changed the title [7275] adds mem cache for api endpoints [7275] adds cache for api endpoints Oct 4, 2023
@hklarner hklarner force-pushed the hk-2023-10-api-caching branch from 6f3ca5b to 7797e44 Compare October 5, 2023 09:01
@hklarner hklarner force-pushed the hk-2023-10-api-caching branch 2 times, most recently from 7797e44 to 655f9ff Compare October 5, 2023 11:11
@hklarner hklarner force-pushed the hk-2023-10-api-caching branch 2 times, most recently from 245bce2 to 71a8242 Compare October 5, 2023 13:50
m4ra
m4ra reviewed Oct 5, 2023
View reviewed changes
Copy link
Contributor

@m4ra m4ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
it would be good to have a test for the list views, by checking cache keys inline, before and after calling the list view. Before the GET, cache doesn't have the key, after it does. then remove the key from the cache at the end of test case.

meinberlin/apps/projects/apps.py Outdated Show resolved Hide resolved
@hklarner hklarner force-pushed the hk-2023-10-api-caching branch 3 times, most recently from 1b7bf1d to 307b513 Compare October 9, 2023 11:07
@hklarner hklarner requested a review from m4ra October 9, 2023 11:07
@hklarner hklarner force-pushed the hk-2023-10-api-caching branch from 307b513 to ffea8ce Compare October 9, 2023 11:09
m4ra
m4ra reviewed Oct 9, 2023
View reviewed changes
meinberlin/apps/projects/api.py Outdated Show resolved Hide resolved
tests/contrib/test_caching.py Outdated Show resolved Hide resolved
m4ra
m4ra reviewed Oct 9, 2023
View reviewed changes
tests/contrib/test_caching.py Outdated Show resolved Hide resolved
m4ra
m4ra reviewed Oct 9, 2023
View reviewed changes
tests/contrib/test_caching.py Outdated Show resolved Hide resolved
@hklarner hklarner force-pushed the hk-2023-10-api-caching branch 2 times, most recently from 3e9f12f to 84ce7fd Compare October 9, 2023 14:03
@hklarner hklarner requested a review from m4ra October 9, 2023 14:03
@hklarner hklarner force-pushed the hk-2023-10-api-caching branch 6 times, most recently from aaf8d75 to 56804bc Compare October 10, 2023 11:45
m4ra
m4ra reviewed Oct 10, 2023
View reviewed changes
docs/caching.md Outdated Show resolved Hide resolved
@hklarner hklarner force-pushed the hk-2023-10-api-caching branch from 56804bc to 81b76c4 Compare October 10, 2023 12:42
m4ra
m4ra requested changes Oct 10, 2023
View reviewed changes
meinberlin/apps/contrib/caching.py Outdated Show resolved Hide resolved
tests/contrib/test_caching.py Outdated Show resolved Hide resolved
tests/contrib/test_caching.py Outdated Show resolved Hide resolved
tests/contrib/test_caching.py Outdated Show resolved Hide resolved
tests/contrib/test_caching.py Outdated Show resolved Hide resolved
tests/contrib/test_caching.py Outdated Show resolved Hide resolved
tests/contrib/test_caching.py Outdated Show resolved Hide resolved
@hklarner hklarner force-pushed the hk-2023-10-api-caching branch 7 times, most recently from b3db79a to d7c63cc Compare October 11, 2023 12:32
m4ra
m4ra requested changes Oct 11, 2023
View reviewed changes
meinberlin/apps/plans/signals.py Outdated Show resolved Hide resolved
meinberlin/apps/projectcontainers/signals.py Outdated Show resolved Hide resolved
@hklarner hklarner force-pushed the hk-2023-10-api-caching branch from d7c63cc to afe09eb Compare October 11, 2023 17:14
@hklarner hklarner requested review from m4ra and goapunk October 11, 2023 17:26
@m4ra m4ra closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4ra m4ra Awaiting requested review from m4ra

@goapunk goapunk Awaiting requested review from goapunk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hklarner @goapunk @m4ra