Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8473] add kiezradar models #5740

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

m4ra
Copy link
Contributor

@m4ra m4ra commented Nov 12, 2024

Describe your changes

  • A Kiezradar query with a text field which can accommodate free text query.
  • A search profile related to user, corresponds to the project overview filters, and which has a m2m relation with the existing project overview filters. The idea is that these filter can be multiselected and attached to different Search Profiles.
  • A Serializer with a custom create() and update() to creating/updating m2m relations of the SearchProfile.

Tasks

  • PR name contains story or task reference
  • Steps to recreate and test the changes
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@m4ra m4ra changed the title apps: add kiezradar models [8473] add kiezradar models Nov 12, 2024
@m4ra m4ra changed the title [8473] add kiezradar models WIP [8473] add kiezradar models Nov 12, 2024
@m4ra m4ra force-pushed the mk-2024-11-kiezradar-search-profile-dev branch 2 times, most recently from 48ccbd5 to 312553f Compare November 12, 2024 15:59
@m4ra m4ra changed the title WIP [8473] add kiezradar models [8473] add kiezradar models Nov 12, 2024
@m4ra m4ra requested a review from goapunk November 12, 2024 16:06
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some questions and a note regarding providing_args

meinberlin/apps/kiezradar/signal.py Outdated Show resolved Hide resolved
meinberlin/apps/kiezradar/models.py Outdated Show resolved Hide resolved
meinberlin/apps/kiezradar/views.py Outdated Show resolved Hide resolved
@m4ra m4ra force-pushed the mk-2024-11-kiezradar-search-profile-dev branch from 312553f to 33f6706 Compare November 19, 2024 18:07
@m4ra m4ra requested a review from goapunk November 19, 2024 18:09
@m4ra m4ra force-pushed the mk-2024-11-kiezradar-search-profile-dev branch 2 times, most recently from 7619a7f to 9143f18 Compare November 21, 2024 12:46
@m4ra m4ra force-pushed the mk-2024-11-kiezradar-search-profile-dev branch from 9143f18 to f938401 Compare November 21, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants