Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apply/mint interest for redemptions and leave redeemed Troves open #102

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

RickGriff
Copy link
Collaborator

@RickGriff RickGriff commented Apr 9, 2024

  • Addresses most of Redeem in order of interest rate #55
  • Leaves fully redeemed Troves open with debt == BOLD_GAS_COMPENSATION.
  • TODO: "Zombie" Trove logic. Fully-redeemed-from Troves are currently just left in the sorted list (and will be skipped by future redemptions). Later we'll remove any Troves with debt < MIN_NET_DEBT from the sorted list, so they don't clog up redemption sequences.

@RickGriff RickGriff requested a review from bingen April 9, 2024 11:36
Copy link
Collaborator

@bingen bingen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This looks good to me!

@RickGriff RickGriff changed the base branch from refactor_active_pool_calls to main April 10, 2024 04:46
@RickGriff RickGriff merged commit 7e4b362 into main Apr 10, 2024
5 of 6 checks passed
@danielattilasimon danielattilasimon deleted the redemption_interest_2 branch April 12, 2024 06:15
@bingen bingen mentioned this pull request Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants