Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove network enforcing screen #118

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Conversation

bpierre
Copy link
Contributor

@bpierre bpierre commented Apr 15, 2024

Note: the base branch is temporarily set to remove-network-enforcing-screen for diff readability, it should be set back to main once #117 gets merged.

@bpierre bpierre changed the base branch from main to app-env-consistency April 15, 2024 16:46
@bpierre bpierre changed the base branch from app-env-consistency to main April 15, 2024 17:37
Comment on lines -25 to -27
<EnforceChain>
{children}
</EnforceChain>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this yesterday because I couldn’t solve a mysterious wagmi runtime error happening only with Chromium (but not Chrome with the exact same version 🤨), but it got solved today after resetting it: it was probably caused by one of the flags I had activated.

Copy link
Collaborator

@danielattilasimon danielattilasimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍 👍

frontend/src/app/contracts/page.tsx Outdated Show resolved Hide resolved
@bpierre bpierre merged commit c17f4af into main Apr 16, 2024
@bpierre bpierre deleted the remove-network-enforcing-screen branch April 16, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants