GitHub Actions: pin foundry version #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielattilasimon
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
It's probably this bug:
foundry-rs/foundry#7702
Let's merge this and monitor the issue in Foundry. Once it's fixed, it would be best if we switch back to latest nightly. The reason being that we (as devs) usually just install the latest nightly from time to time with foundryup, so it's good to learn about breakages such as this, so we can avoid bad versions.
Indeed!
That sounds reasonable yes 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the latest version (
nightly) and contracts verification https://github.com/liquity/bold/actions/runs/8734315602/job/23964899137#step:7:194