Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: define the CI env var when running in CI #137

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Conversation

danielattilasimon
Copy link
Collaborator

This will tell pnpm to use --frozen-lockfile.

const envVars = [
`DEPLOYER=${options.deployer}`,
];
process.env.DEPLOYER = options.deployer;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaner 💯

This will tell pnpm to use --frozen-lockfile.
It should automatically use --frozen-lockfile when detecting CI,
but that doesn't seem to work for some reason.
Copy link
Contributor

@bpierre bpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Hardhat tests were failing when installing dependencies via pnpm v9, why?
@danielattilasimon danielattilasimon merged commit 5b5836c into main Apr 30, 2024
7 checks passed
@danielattilasimon danielattilasimon deleted the define-ci branch May 6, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants