refactor: eliminate recordedDebtSum (G) from ActivePool
#150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the perspective of the core system, it was a write-only variable. It would have been used in: - the emergency minimum rate, which won't be implemented, - approximation of the the size-weighted interest rate, which can be done alternatively (albeit less accurately) using S & D.
RickGriff
approved these changes
May 6, 2024
| @@ -1116,7 +1116,7 @@ contract("BorrowerOperations", async (accounts) => { | |||
| assert.isTrue(aliceDebtBefore.gt(toBN(0))); | |||
|
|
|||
| // check before | |||
| const activePool_Bold_Before = await activePool.getRecordedDebtSum(); | |||
| const activePool_Bold_Before = await activePool.getTotalActiveDebt(); | |||
There was a problem hiding this comment.
Right, we can swap getRecordedDebtSum out for getTotalActiveDebt in these HH tests presumably because no interest accrues between "before" and "after".
Good call! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the perspective of the core system, it was a write-only variable.
It would have been used in:
Also, change some function names in ActivePool to improve readability. The function
mintAggInterest()has 2 versions:mintAggInterestNoTroveChange(): mints aggregate interest,mintAggInterest(): mints aggregate interest and accounts for Trove changes (in debt or interest rate).Rather than saying what a function doesn't do, it's more helpful to say what it does, so:
mintAggInterestNoTroveChange()mintAggInterest()mintAggInteres()mintAggInterestAndAccountForTroveChange()