Optional claim/stash SP ETH rewards #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RickGriff
force-pushed
the
stash_sp_rewards
branch
from
d9d84ac
to
c087ca6
Compare
bingen
approved these changes
May 7, 2024
contracts/src/StabilityPool.sol
Outdated
|
|
||
| // If they have a deposit, update it and update its snapshots | ||
| if (initialDeposit > 0) { | ||
| currentETHGain = getDepositorETHGain(msg.sender); // Only active deposits can only have a current ETH gain |
There was a problem hiding this comment.
I guess only one only is enough 😉
There was a problem hiding this comment.
Only one comment? I was trying to say two things here: the second line aims to point out that their current gain must be zero if their deposit initial value is zero.
There was a problem hiding this comment.
I meant that the second comment says “only” twice. And I guess it doesn’t mean that active deposits cannot have stashed gains.
There was a problem hiding this comment.
Oh! haha, right. Should just be one. Fixed.
contracts/src/StabilityPool.sol
Outdated
| uint256 stashedETHGain = stashedETH[msg.sender]; | ||
| uint256 ETHToSend = currentETHGain + stashedETHGain; | ||
|
|
||
| stashedETH[msg.sender] = 0; |
There was a problem hiding this comment.
Aren’t these 3 lines the same as _getTotalETHGainAndZeroStash? Can’t we reuse that function?
There was a problem hiding this comment.
Right, good point! I've refactored that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doClaimwhen providing/withdrawing from SP. They can choose to either have their ETH gains paid out, or stashed for future claimingclaimAllETHGainspays out a depositor's total ETH gain (current gains accrued since last touch, and stashed gains)Closes #122