Pay portion of interest to SP depositors #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RickGriff
force-pushed
the
bold_sp_rewards_direct_2
branch
from
69e9807
to
aff2ce7
Compare
RickGriff
force-pushed
the
bold_sp_rewards_direct_2
branch
from
7a8b7ce
to
6dfb30c
Compare
bingen
approved these changes
May 20, 2024
contracts/src/StabilityPool.sol
Outdated
| uint256 stashedETHGain = stashedETH[_depositor]; | ||
| uint256 totalETHGain = stashedETHGain + _currentETHGain; | ||
|
|
||
| // TODO: Gas - saves gas when stashedETHGain == 0? | ||
| if (stashedETHGain > 0) stashedETH[_depositor] = 0; | ||
| if (stashedETHGain > 0) {stashedETH[_depositor] = 0;} |
There was a problem hiding this comment.
I’m fine either way, but I think forge fmt removes this, so if we keep using it I’m afraid this will be reverted.
| boldLoss = initialDeposit - compoundedBoldDeposit; // Needed only for event log | ||
| assert(stashedETH[msg.sender] == 0); | ||
| assert(getDepositorETHGain(msg.sender) == 0); | ||
| assert(getDepositorYieldGain(msg.sender) == 0); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #47