fix: Fix lastInterestRateAdjTime when leaving/joining batches #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add tests and a section to README.
😭 😭 Edit: nevermind, I guess it's because of the commit it's based on, not any changes in this PR, so it should be fine once merged. |
Yes, that was fixed here: |
danielattilasimon
force-pushed
the
document_batch_upfrontfee
branch
from
c98e957
to
4c6bfa8
Compare
cvalkan
reviewed
Aug 29, 2024
| ##### Joining a batch | ||
| When a trove joins a batch, it pays upfront fee if the last trove adjustment was done more than the cool period ago. It does’t matter if trove and batch have the same interest rate, or when was the last adjustment by the batch. | ||
|
|
||
| The last interest rate timestamp will be updated to the time of joining. |
There was a problem hiding this comment.
Perhaps we could specify "The trove's last interest ..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add tests and a section to README.