Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Attributes to URI #410

Merged
merged 7 commits into from
Sep 18, 2024
Merged

Add Attributes to URI #410

merged 7 commits into from
Sep 18, 2024

Conversation

cupOJoseph
Copy link
Contributor

@cupOJoseph cupOJoseph commented Sep 4, 2024

this is what the URI should look like:

{
  "description": "....", 
  "external_url": "...", //havent set one of these yet
  "image": "base64 stuff here", 
  "name": "...",
  "attributes": 
[
    {"trait_type": "Collateral Token", "value": 0xabc123},
    {"trait_type": "Collateral Amount", "value": 5000000000000000},
    ...
 ]
}

json is now valid and contains useful info. Example output:
https://gist.github.com/cupOJoseph/ac67c2af41e77f2e829f9a5bd0aa9140

We should have some direct tests of the output too possibly, so I added a to-do. in the test file.

@cupOJoseph
Copy link
Contributor Author

looks like failing tests might be unrelated? I think this is ready for review

@ColinPlatt ColinPlatt merged commit 6959eb5 into liquity:main Sep 18, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants