-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App: trove transaction flows (open / update / close) #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See subgraph/README.md for instructions on how to deploy the subgraph locally. - Add subgraph/ to the workspaces. - A script, ./deploy-subgraph, can be used to deploy the subgraph in a convenient way. See --help for details. Some context: - The subgraph uses subgraph templates for the collateral contracts. - The script can update the collateral registry address in the subgraph.yaml if it doesn’t match the one found in the latest deployment context. - In ./deploy-subgraph, only the local preset is implemented.
This allows to initiate things when `CollateralRegistryAddressChanged` gets emitted on BoldToken, which happens at the very end of the deployment process. Also: - Use troveNFT.ownerOf() to determinate the trove owner. - Update README instructions.
- Add ./start-graph - Remove ./docker-cleanup.sh (replaced by ./start-graph --reset) - Rename ./deploy to ./deploy-subgraph for clarity - Update README with new instructions
…anges related to the openLoanPosition tx flow
- Remove flowStatus entirely (now deducted from the steps statuses) - Many other changes around transactions handling
bpierre
changed the title
App: open trove transaction flow
App: trove transaction flows (open / update / close)
Sep 24, 2024
bpierre
changed the title
App: trove transaction flows (open / update / close)
App: trove transaction flows (open / update / close) + Sepolia
Sep 24, 2024
bpierre
changed the title
App: trove transaction flows (open / update / close) + Sepolia
App: trove transaction flows (open / update / close)
Sep 24, 2024
bpierre
added a commit
that referenced
this pull request
Sep 26, 2024
These were unintentionally introduced by git merge conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builds on #420 which should be merged before
Also add changes related to the deployment to Sepolia.