Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App: trove transaction flows (open / update / close) #422

Merged
merged 58 commits into from
Sep 24, 2024
Merged

Conversation

bpierre
Copy link
Contributor

@bpierre bpierre commented Sep 13, 2024

builds on #420 which should be merged before

  • Generic transaction page
  • Borrowing tx flow
  • Loan update tx flow
  • Loan rate tx flow
  • Closing flow tx flow

Also add changes related to the deployment to Sepolia.

See subgraph/README.md for instructions on how to deploy the subgraph locally.

- Add subgraph/ to the workspaces.
- A script, ./deploy-subgraph, can be used to deploy the subgraph in a
  convenient way. See --help for details.

Some context:

- The subgraph uses subgraph templates for the collateral contracts.
- The script can update the collateral registry address in the
  subgraph.yaml if it doesn’t match the one found in the latest
  deployment context.
- In ./deploy-subgraph, only the local preset is implemented.
This allows to initiate things when `CollateralRegistryAddressChanged`
gets emitted on BoldToken, which happens at the very end of the
deployment process.

Also:

- Use troveNFT.ownerOf() to determinate the trove owner.
- Update README instructions.
- Add ./start-graph
- Remove ./docker-cleanup.sh (replaced by ./start-graph --reset)
- Rename ./deploy to ./deploy-subgraph for clarity
- Update README with new instructions
…anges related to the openLoanPosition tx flow
Base automatically changed from app-subgraph to main September 24, 2024 12:57
@bpierre bpierre marked this pull request as ready for review September 24, 2024 13:27
@bpierre bpierre changed the title App: open trove transaction flow App: trove transaction flows (open / update / close) Sep 24, 2024
@bpierre bpierre changed the title App: trove transaction flows (open / update / close) App: trove transaction flows (open / update / close) + Sepolia Sep 24, 2024
@bpierre bpierre changed the title App: trove transaction flows (open / update / close) + Sepolia App: trove transaction flows (open / update / close) Sep 24, 2024
@bpierre bpierre merged commit 235c05c into main Sep 24, 2024
7 checks passed
@bpierre bpierre deleted the app-open-trove-tx branch September 24, 2024 19:34
bpierre added a commit that referenced this pull request Sep 26, 2024
These were unintentionally introduced by git merge conflicts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant