chore: provide liquidity for zappers on Sepolia #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingen
approved these changes
Oct 16, 2024
|
|
||
| contract DeployLiquity2Script is Script, StdCheats, MetadataDeployment { | ||
| using Strings for *; | ||
| using StringFormatting for *; | ||
|
|
||
| uint24 constant UNIV3_FEE = 0.3e4; |
There was a problem hiding this comment.
Interesting format! I would have expected 3000 or 3e3 😅
There was a problem hiding this comment.
It stands for 0.3% 😜
|
|
||
| if (block.chainid == 11155111) { | ||
| // Provide liquidity for zaps if we're on Sepolia | ||
| ERC20Faucet monkeyBalls = new ERC20Faucet("MonkeyBalls", "MB", 0, type(uint256).max); |
| internal | ||
| returns (DeploymentResult memory r) | ||
| { | ||
| // Solidity... |
There was a problem hiding this comment.
I can't fathom why you can't cast an array of subclasses into an array of superclasses, not even explicitly, when the elements themselves can be implicitly cast. What are we supposed to do, create a new copy of the array just so we can end up with the exact same representation?
This allows for richer output, like color and progress bars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, we're only deploying Uni v3 pools/zappers, no Curve.