fix: Allow borrowing if it brings TCR back up to CCR #527
Conversation
|
So all along, opening a Trove below CCR was okay as long as it would tip the TCR above CCR? But borrowing against an existing Trove was a no-go. Well, it's good that we're making it consistent then. |
|
No, I think it was already consistent, see here: The aim is to fix the issue brought up by Alex, where a whale may block borrowing in general (both new and existing troves) by being able to place the system slightly below CCR. |
|
Ah, I see, I missed the check being removed from |
| @@ -1350,26 +1347,14 @@ contract BorrowerOperations is LiquityBase, AddRemoveManagers, IBorrowerOperatio | |||
| } | |||
| } | |||
|
|
|||
| function _requireNotBelowCriticalThreshold(uint256 _price) internal view { | |||
| if (_checkBelowCriticalThreshold(_price, CCR)) { | |||
| revert BelowCriticalThreshold(); | |||
There was a problem hiding this comment.
This makes error BelowCriticalThreshold() unused, I believe.
There was a problem hiding this comment.
Oh, right, I removed BorrowingNotPermittedBelowCT but forgot this one. Thanks for fixing it!
|
And thanks for fixing the invariant tests too! |
Fixes #511