Add basic dev test setup #59
Conversation
There was a problem hiding this comment.
Looking good, thanks!!
I left some minor comments inline.
One more generic one, related to the deployment testing, I think we should look into this:
https://github.com/ChainSecurity/deployment_validation
(Do you remember? We watch the presentation about it in Paris)
| pragma solidity 0.8.18; | ||
|
|
||
| interface IGasPool { | ||
| // empty |
There was a problem hiding this comment.
Curious: why is this needed?
There was a problem hiding this comment.
Hmm that was to be consistent with declaring interfaces in BaseTest then deploying in DevTestSetup. I've changed this so we just declare the contract GasPool in BaseTest rather than the interface (and deleted the interface). An empty interface is awkward.
contracts/src/test/deployment.t.sol
Outdated
|
|
||
| // Active Pool | ||
|
|
||
| function testActivePoolHasCorrectActivePoolAddress() public { |
There was a problem hiding this comment.
I guess the 2nd one should be Stability instead of Active
contracts/src/test/deployment.t.sol
Outdated
|
|
||
| // Sorted Troves | ||
|
|
||
| function testSortedTrovesHasCorrectTroveManagerAddress() public { |
There was a problem hiding this comment.
Name is mixed with the test below
|
Definitely, I like the idea of deployment validation. It's another layer of security assurance for users, and will be a good fit for Bold since the system won't be upgradeable. Assuming we use ChainSecurity for an audit we can discuss it with them. |
Add a basic dev environment test setup - deploying and connecting core contracts, using a testnet PriceFeed - to allow testing in Solidity with Foundry.