Remove fees (borrow and redeem) and SP logic for LQTY and front ends #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingen
approved these changes
Jan 22, 2024
| @@ -0,0 +1,9 @@ | |||
| // SPDX-License-Identifier: MIT | |||
There was a problem hiding this comment.
Should this be in any of the test folders?
There was a problem hiding this comment.
Yes fair point.
We now have contracts/src/test/TestContracts for new test contracts exclusive to Foundry tests, and the original contracts/src/TestContracts used by the Hardhat tests.
contracts/src/TroveManager.sol
Outdated
| @@ -13,6 +13,7 @@ import "./Dependencies/LiquityBase.sol"; | |||
| import "./Dependencies/Ownable.sol"; | |||
| import "./Dependencies/CheckContract.sol"; | |||
|
|
|||
| import "forge-std/console2.sol"; | |||
There was a problem hiding this comment.
Github CI should warn, and we have plenty of time to remove it, but just in case.
contracts/src/test/basicOps.t.sol
Outdated
| assertEq(boldToken.balanceOf(A), 1900e18); | ||
| assertEq(stabilityPool.getCompoundedBoldDeposit(A), 100e18); | ||
|
|
||
| // A tops up their SP deposit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.