Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contracts: move to pnpm #88

Merged
merged 5 commits into from
Apr 3, 2024
Merged

Contracts: move to pnpm #88

merged 5 commits into from
Apr 3, 2024

Conversation

bpierre
Copy link
Contributor

@bpierre bpierre commented Apr 3, 2024

No description provided.

uses: pnpm/action-setup@v3.0.0

- name: Install Node.js
uses: actions/setup-node@v4
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also moved to the latest version of actions/setup-node (v3 => v4)

Copy link
Collaborator

@bingen bingen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but the CI needs to be fixed)


- uses: actions/setup-node@v4
with:
node-version-file: '.node-version'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is complaining about this. I guess we need to create that file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I added it 👍

@bpierre bpierre marked this pull request as ready for review April 3, 2024 10:12
@bpierre bpierre merged commit 6a755d0 into main Apr 3, 2024
5 of 6 checks passed
@bpierre bpierre deleted the contracts-pnpm branch April 3, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants