Refactor ActivePool interest tracker calls into one mintAggInterest call #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RickGriff
force-pushed
the
refactor_active_pool_calls
branch
from
d558ff1
to
4265a00
Compare
bingen
approved these changes
Apr 8, 2024
| @@ -596,14 +611,9 @@ contract BorrowerOperations is LiquityBase, Ownable, CheckContract, IBorrowerOpe | |||
| internal | |||
| { | |||
| if (_isDebtIncrease) { | |||
| _activePool.increaseRecordedDebtSum(_boldChange + _accruedTroveInterest); | |||
There was a problem hiding this comment.
Should we change the comments in the header now?
There was a problem hiding this comment.
Good call. And we also actually don't need the _accruedTroveInterest param now.
| @@ -866,9 +869,7 @@ contract TroveManager is ERC721, LiquityBase, Ownable, CheckContract, ITroveMana | |||
| * Any surplus ETH left in the trove, is sent to the Coll surplus pool, and can be later claimed by the borrower. | |||
| */ | |||
| function _redeemCloseTrove(ContractsCache memory _contractsCache, uint256 _troveId, uint _bold, uint _ETH) internal { | |||
| _contractsCache.boldToken.burn(gasPoolAddress, _bold); | |||
| // Update Active Pool Bold, and send ETH to account | |||
| _contractsCache.activePool.decreaseRecordedDebtSum(_bold); | |||
There was a problem hiding this comment.
I guess we are aggregating this outside the loop in the external function redeemCollateral? But I can find its replacement.
There was a problem hiding this comment.
Right, this is now handled in the redemption interest PR:
#101
| @@ -209,8 +209,10 @@ contract InterestRateAggregate is DevTestSetup { | |||
| priceFeed.setPrice(2000e18); | |||
| assertEq(activePool.aggRecordedDebt(), 0); | |||
|
|
|||
| console.log("here 1"); | |||
There was a problem hiding this comment.
If this works maybe we can remove this now ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.