Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend scaffolding #99

Merged
merged 44 commits into from
Apr 5, 2024
Merged

Frontend scaffolding #99

merged 44 commits into from
Apr 5, 2024

Conversation

bpierre
Copy link
Contributor

@bpierre bpierre commented Apr 5, 2024

No description provided.

danielattilasimon and others added 30 commits February 2, 2024 14:40
- Add panda-css + react-spring
- Load vars from environment (see env.ts)
- README instructions
- dprint / formatting
Remove patterns targetting yarn, npm and panda.
This commit moves back from StyleX to Panda CSS.

StyleX is exclusively relying on a babel transform, which causes issues
with new tools and libraries where the general consensus is to avoid
relying on Babel, mostly for performances reasons.

Next has a Babel mode which I activated for StyleX, but it comes with a
few downsides:

- The compilation becomes much slower than with swc [1].
- I encountered one feature missing in this mode [2].
- It can create some tricky issues with external libraries, like
  RainbowKit and ConnectKit (which both embed client-side libraries
  relying on Node APIs).

The StyleX team is currently working on a solution that would allow to
not rely on Babel anymore [3], but it is not ready yet. For these
reasons and rather than spending too much time on these issues, I think
Panda would be the better option for SSR-compatible styles.

[1] https://swc.rs/
[2] https://nextjs.org/docs/messages/babel-font-loader-conflict
[3] facebook/stylex#412
- useOpenTrove()
- useCloseTrove()
- useBoldBalance()

Also add contracts.ts which contains structures representing each
contract with their ABI.
@bpierre bpierre marked this pull request as ready for review April 5, 2024 13:23
@bpierre bpierre merged commit 1694b46 into main Apr 5, 2024
1 check passed
@danielattilasimon danielattilasimon deleted the scaffold branch April 12, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants