-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Home Assistant Red Alert app #212
Conversation
Added this Home Alert integration for the Red Alert / Pikud HaOref system (language: Python)
This reverts commit dd7b5be.
Added the Red Alert Home Assistant integration (one of two!). Tried my best to avoid whitespaces in the TOS!
README.md
Outdated
- [Israeli Tech AwesomeLists](#israeli-tech-awesomelists) | ||
- [Contributing](#contributing) | ||
- [License](#license) | ||
- [Table of Contents](#table-of-contents) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielrosehill can you please remove this change to the table of contents? that's not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lirantal - It's automatic indentation from VS Code indenting everything by one space forward whenever I save the file. Driving me crazy trying to stop it from happening. Let me see if I can figure it out and create a new PR (you might be able to see from the commits that I already tried once unsuccessfully!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the problem is that it's indenting one level deep.
feel free to close this PR and make changes only to the other section in the README to add your project and submit a new PR with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do!
README.md
Outdated
@@ -217,6 +218,7 @@ ic research to an artifact that engineers can deploy easily. ![GitHub last commi | |||
* [PySnooper](https://github.com/cool-RR/PySnooper) - a Python debugging aid. "Never use print for debugging again." ![GitHub last commit](https://img.shields.io/github/last-commit/cool-RR/PySnooper?style=flat-square) ![GitHub top language](https://img.shields.io/github/languages/top/cool-RR/PySnooper?style=flat-square) | |||
![GitHub stars](https://img.shields.io/github/stars/cool-RR/PySnooper?style=flat-square) | |||
* [Redash](https://github.com/getredash/redash) - Data visualization tool for building dashboards that connect to multiple data sources. ![GitHub last commit](https://img.shields.io/github/last-commit/getredash/redash?style=flat-square) ![GitHub top language](https://img.shields.io/github/languages/top/getredash/redash?style=flat-square) | |||
* * [Red Alert (Home Assistant Integration)](https://github.com/idodov/RedAlert) - Home Assistant component for providing alerts from the Israeli Home Front Command system and making them available as sensors in Home Assistant. ![GitHub last commit](https://img.shields.io/github/last-commit/idodov/RedAlert?style=flat-square) ![GitHub top language](https://img.shields.io/github/languages/top/idodov/RedAlert?style=flat-square) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and I'd love to add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielrosehill note that we didn't end up merging this change
Used a different IDE with a different setting to remove the problematic space handling
Fixed the spacing on the addition itself and corrected the link for the stars
I tried but failed to figure out what was going on with the markdown in VSCode (see the TOS where it's added a bunch of indents that I can't seem to get rid of. Sorry .. but I also wanted to use this PR to see if adding Home Assistant components was okay as there are a few that I'd be happy to send in.